fix(describe-pp): show output on successive runs #10340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/describe-pp-force
branch
from
3a6e012 to
e0fff6e
Compare
rgrinberg
reviewed
Mar 30, 2024
rgrinberg
approved these changes
Mar 30, 2024
anmonteiro
force-pushed
the
anmonteiro/describe-pp-force
branch
from
e0fff6e to
8ecd748
Compare
|
@rgrinberg I pushed a version that uses |
anmonteiro
force-pushed
the
anmonteiro/describe-pp-force
branch
from
8ecd748 to
4b75925
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/describe-pp-force
branch
from
4b75925 to
70f28f9
Compare
rgrinberg
approved these changes
Apr 1, 2024
pmwhite
pushed a commit
to pmwhite/dune
that referenced
this pull request
Apr 2, 2024
* fix(describe-pp): show output on successive runs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * code-review: use Action_exec.exec instead Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refmt#10322 introducedBuild_system.execute_actionwhich is cached(universe)to the anonymous action obtained in the dialect so that output is always shown after runningdune describe pp