Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: show crash when defining a context named "install" #10472

Merged

Conversation

anmonteiro
Copy link
Collaborator

There's a special Install.Context module that tracks this context.

log is already forbidden as a name in Context_name.of_string_opt, but "install" is a bit of a special case.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/show-crash-context-name-install branch from 1e597b0 to 9f07676 Compare May 1, 2024 00:04
@anmonteiro anmonteiro merged commit 7b5c579 into ocaml:main May 1, 2024
26 of 27 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/show-crash-context-name-install branch May 1, 2024 17:29
anmonteiro added a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants