-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add merlin_reader
to the (dialect ...)
documentation
#10483
Merged
anmonteiro
merged 5 commits into
ocaml:main
from
anmonteiro:anmonteiro/doc-for-merlin-reader
May 14, 2024
Merged
doc: add merlin_reader
to the (dialect ...)
documentation
#10483
anmonteiro
merged 5 commits into
ocaml:main
from
anmonteiro:anmonteiro/doc-for-merlin-reader
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreypopp
reviewed
May 5, 2024
emillon
reviewed
May 6, 2024
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Co-authored-by: Andrey Popp <8mayday@gmail.com> Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/doc-for-merlin-reader
branch
from
May 7, 2024 21:35
11d400c
to
2b7cafe
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/doc-for-merlin-reader
branch
from
May 7, 2024 22:15
2b7cafe
to
e5623de
Compare
Thanks for your review, @emillon. I added a stable URL and a |
emillon
approved these changes
May 14, 2024
MA0010
pushed a commit
to MA0010/dune
that referenced
this pull request
Jun 5, 2024
…10483) * doc: add `merlin_reader` to the `(dialect ...)` documentation Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * Update doc/reference/dune-project/dialect.rst Co-authored-by: Andrey Popp <8mayday@gmail.com> Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix: grammar Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix: use seealso and a stable tag Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Co-authored-by: Andrey Popp <8mayday@gmail.com> Co-authored-by: Etienne Millon <me@emillon.org>
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
…10483) * doc: add `merlin_reader` to the `(dialect ...)` documentation Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * Update doc/reference/dune-project/dialect.rst Co-authored-by: Andrey Popp <8mayday@gmail.com> Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix: grammar Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * fix: use seealso and a stable tag Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Co-authored-by: Andrey Popp <8mayday@gmail.com> Co-authored-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #8567
cc @andreypopp