Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add merlin_reader to the (dialect ...) documentation #10483

Merged
merged 5 commits into from
May 14, 2024

Conversation

anmonteiro
Copy link
Collaborator

follow-up to #8567

cc @andreypopp

@anmonteiro anmonteiro requested a review from emillon May 5, 2024 23:17
anmonteiro and others added 3 commits May 7, 2024 14:35
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Co-authored-by: Andrey Popp <8mayday@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/doc-for-merlin-reader branch from 11d400c to 2b7cafe Compare May 7, 2024 21:35
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/doc-for-merlin-reader branch from 2b7cafe to e5623de Compare May 7, 2024 22:15
@anmonteiro anmonteiro requested a review from emillon May 7, 2024 22:26
@anmonteiro
Copy link
Collaborator Author

Thanks for your review, @emillon. I added a stable URL and a seealso block.

@anmonteiro anmonteiro merged commit a55af46 into ocaml:main May 14, 2024
28 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/doc-for-merlin-reader branch May 14, 2024 16:09
MA0010 pushed a commit to MA0010/dune that referenced this pull request Jun 5, 2024
…10483)

* doc: add `merlin_reader` to the `(dialect ...)` documentation

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* Update doc/reference/dune-project/dialect.rst

Co-authored-by: Andrey Popp <8mayday@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* fix: grammar

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* fix: use seealso and a stable tag

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

---------

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Co-authored-by: Andrey Popp <8mayday@gmail.com>
Co-authored-by: Etienne Millon <me@emillon.org>
anmonteiro added a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
…10483)

* doc: add `merlin_reader` to the `(dialect ...)` documentation

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* Update doc/reference/dune-project/dialect.rst

Co-authored-by: Andrey Popp <8mayday@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* fix: grammar

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* fix: use seealso and a stable tag

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

---------

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Co-authored-by: Andrey Popp <8mayday@gmail.com>
Co-authored-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants