Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(melange): add a test showing dependent re-compilation #10501

Merged

Conversation

anmonteiro
Copy link
Collaborator

this is the last test case we were missing from #7164

I feel like there's a missing optimization here, where only lib/foo.ml should be recompiled, but instead all its dependents end up getting recompiled, too.

@anmonteiro anmonteiro requested review from rgrinberg and jchavarri May 9, 2024 23:06
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/test-melange-recompile-dependents branch from 187390f to d26c4c4 Compare May 9, 2024 23:18
Copy link
Collaborator

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be adding deps on ml files when it should be only mli. I wonder if there's a similar test for executables?

@anmonteiro anmonteiro enabled auto-merge (squash) May 13, 2024 21:50
@anmonteiro anmonteiro merged commit f51d90b into ocaml:main May 13, 2024
1 of 2 checks passed
@anmonteiro
Copy link
Collaborator Author

This is likely because we depend on the .cmj rather than any source dependencies.

@anmonteiro anmonteiro deleted the anmonteiro/test-melange-recompile-dependents branch May 13, 2024 21:50
anmonteiro added a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants