Fix interpretation of 'exists_if' in META files #10564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
dbuenzli
approved these changes
May 23, 2024
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
May 24, 2024
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
May 24, 2024
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
added a commit
that referenced
this pull request
May 24, 2024
* Fix interpretation of 'exists_if' in META files (#10564) Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com> * Add fixes Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com> Signed-off-by: Etienne Millon <me@emillon.org> Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
May 24, 2024
CHANGES: ### Fixed - Fix interpretation of `exists_if` predicate in `META` files of installed libraries containing more than one element. (ocaml/dune#10564, fixes ocaml/dune#10563, @dbuenzli, @nojb) - Fix TSAN warning in wait4 stubs (ocaml/dune#10554, fixes ocaml/dune#10553, @emillon)
MA0010
pushed a commit
to MA0010/dune
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: ### Fixed - Fix interpretation of `exists_if` predicate in `META` files of installed libraries containing more than one element. (ocaml/dune#10564, fixes ocaml/dune#10563, @dbuenzli, @nojb) - Fix TSAN warning in wait4 stubs (ocaml/dune#10554, fixes ocaml/dune#10553, @emillon)
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10563
Both the problem and the fix were suggested by @dbuenzli.