Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce 10582 #10583

Closed
wants to merge 1 commit into from
Closed

Conversation

mt-caret
Copy link

@mt-caret mt-caret commented May 25, 2024

Reproduction of #10582.

Signed-off-by: Masayuki Takeda <mtakeda@oeconomia.jp>
@mt-caret mt-caret force-pushed the mdx-shared-libraries branch from 1f7d922 to 94e28ad Compare May 25, 2024 13:58
@rgrinberg rgrinberg added the mdx label May 25, 2024
@rgrinberg rgrinberg requested a review from emillon May 25, 2024 19:07
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmonteiro feel free to merge if you understand the issue. I added some comments about missing dependencies though

(targets libtest.a dlltest.so)
(action
(progn
(run gcc -c -fPIC test.c -o test.o)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should depend on the gcc binary and ar binaries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in #10586

@anmonteiro
Copy link
Collaborator

Continued in #10586 because this test fails on macOS.

@anmonteiro anmonteiro closed this May 26, 2024
@mt-caret mt-caret deleted the mdx-shared-libraries branch May 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants