refactor: remove action runners from public dune #10794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
commented
Aug 3, 2024
| (Build_config.get ()).action_runners () | ||
| |> Fiber.parallel_iter ~f:Action_runner.cancel_build | ||
| in | ||
| Scheduler.cancel_current_build () |
There was a problem hiding this comment.
This bit is completely broken anyway
Action runners in this dune are a rather old version that it is very much out of date with the state of the actual feature and has many bugs and limitations that need a lot of upstreaming to fix. In its current state, it does not provide any value to users of public dune. If we ever want to upstream this feature, it will be easier to just do it from scratch anyway instead of resolving the conflicts against some old version. This is due to the fact that the action runner API with the engine is rather small and well defined. Once we introduce a better abstraction for action execution (as we are indeed planning), it will be probably be even simpler to upstream action runners. All in all, we gain nothing on either team by keeping this dead weight around. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: b913f829-def9-4d41-90d6-07da8060063b -->
rgrinberg
force-pushed
the
ps/rr/refactor__remove_action_runners_from_public_dune
branch
from
1154bcd to
d40c5aa
Compare
rgrinberg
deleted the
ps/rr/refactor__remove_action_runners_from_public_dune
branch
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Action runners in this dune are a rather old version that it is very much out of date with the state of the actual feature and has many bugs and limitations that need a lot of upstreaming to fix. In its current state, it does not provide any value to users of public dune. If we ever want to upstream this feature, it will be easier to just do it from scratch anyway instead of resolving the conflicts against some old version. This is due to the fact that the action runner API with the engine is rather small and well defined. Once we introduce a better abstraction for action execution (as we are indeed planning), it will be probably be even simpler to upstream action runners. All in all, we gain nothing on either team by keeping this dead weight around. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action runners in this dune are a rather old version that it is very much out of date with the state of the actual feature and has many bugs and limitations that need a lot of upstreaming to fix. In its current state, it does not provide any value to users of public dune.
If we ever want to upstream this feature, it will be easier to just do it from scratch anyway instead of resolving the conflicts against some old version. This is due to the fact that the action runner API with the engine is rather small and well defined.
Once we introduce a better abstraction for action execution (as we are indeed planning), it will be probably be even simpler to upstream action runners.
All in all, we gain nothing on either team by keeping this dead weight around.
cc @snowleopard
Signed-off-by: Rudi Grinberg me@rgrinberg.com