Use [Config.Toggle] for toolchains #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the variable that enables toolchains from DUNE_CONFIG__TOOLCHAINS_ENABLED=[true|false] to DUNE_CONFIG__TOOLCHAINS=[enabled|disabled], following the established convention for such variables in dune, and for compatibility with upcoming support for compile-time configuration. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
toolchains-config-toggle
branch
from
ad4984f to
2b63502
Compare
Leonidas-from-XIV
approved these changes
Aug 8, 2024
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
This changes the variable that enables toolchains from DUNE_CONFIG__TOOLCHAINS_ENABLED=[true|false] to DUNE_CONFIG__TOOLCHAINS=[enabled|disabled], following the established convention for such variables in dune, and for compatibility with upcoming support for compile-time configuration. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the variable that enables toolchains from DUNE_CONFIG__TOOLCHAINS_ENABLED=[true|false] to
DUNE_CONFIG__TOOLCHAINS=[enabled|disabled], following the established convention for such variables in dune, and for compatibility with upcoming support for compile-time configuration.