feat: configure-time-toggles (cont) #10811
Conversation
|
Are you planning on modifying the defaults for any existing configuration values? If not, I don't see why any modifications to dune_config are necessary. |
For the developer preview we'll be enabling |
Leonidas-from-XIV
force-pushed
the
compile-time-toggles
branch
2 times, most recently
from
7cd0ed6 to
989e4ec
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
compile-time-toggles
branch
from
989e4ec to
7bf236b
Compare
|
There's couple of things here that should have never been merged:
|
This reverts commit 7ef8c00.
| @@ -67,3 +69,5 @@ val threaded_console_frames_per_second : [ `Default | `Custom of int ] t | |||
| Note that environment variables take precedence over the values passed here | |||
| for easy overriding. *) | |||
| val init : (Loc.t * string) String.Map.t -> unit | |||
|
|
|||
| val party_mode : Toggle.t t | |||
There was a problem hiding this comment.
This is just a dummy config, do you still need it after testing?
There was a problem hiding this comment.
No, this is just for testing, it can safely be removed. I haven't considered it to be of particular importance but it can be removed without any problem.
|
In particular, here's a way to accomplish what you need without touching dune_config (which we are using internally):
Everything else seems unnecessary |
Signed-off-by: Marek Kubica <marek@tarides.com> Co-authored-by: Etienne Millon <me@emillon.org>
This reverts commit 7ef8c00.
This is a continuation of @emillon's work in #10724; I've rebased that PR and removed the witnesses by adding the toggles to a second-non heterogenous list of config options that only contains the toggles.
I am not sure this was the direction Etienne wanted to take it, so I am creating a new PR for it.