fix(pkg): do not lock unreachable packages #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
reviewed
Aug 12, 2024
gridbugs
reviewed
Aug 12, 2024
gridbugs
reviewed
Aug 12, 2024
|
Looks like a useful change. I have a few readability suggestions but generally happy with this. |
gridbugs
approved these changes
Aug 12, 2024
gridbugs
reviewed
Aug 12, 2024
gridbugs
reviewed
Aug 12, 2024
unreachable packages are those that aren't reachable via the dependencies of local packages typically, such packages are included when solving via post deps Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 32bacf92-e5d4-45c7-bf4f-31cd8d45808a -->
rgrinberg
force-pushed
the
ps/rr/fix_pkg___do_not_lock_unreachable_packages
branch
from
c723a58 to
35bdcab
Compare
gridbugs
approved these changes
Aug 13, 2024
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
unreachable packages are those that aren't reachable via the dependencies of local packages typically, such packages are included when solving via post deps Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unreachable packages are those that aren't reachable via the dependencies of local packages
typically, such packages are included when solving via post deps
Signed-off-by: Rudi Grinberg me@rgrinberg.com