fix: create lock dir parent if missing #10876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiste
force-pushed
the
fix/issue-10866
branch
from
eb124e8 to
c0277a7
Compare
rgrinberg
reviewed
Sep 3, 2024
test/blackbox-tests/test-cases/pkg/lock-directory-regeneration-safety.t/run.t
Show resolved
Hide resolved
maiste
force-pushed
the
fix/issue-10866
branch
from
c0277a7 to
e8af60a
Compare
Signed-off-by: Etienne Marais <dev@maiste.fr>
Signed-off-by: Etienne Marais <dev@maiste.fr>
Signed-off-by: Etienne Marais <dev@maiste.fr>
maiste
force-pushed
the
fix/issue-10866
branch
from
e8af60a to
a8e1ed4
Compare
|
I have split the test in two commits: one before the fix and the next one after the fix is applied. |
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
fix: lock creates parent dir if missing Signed-off-by: Etienne Marais <dev@maiste.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10866. It creates the lock dir if it is missing.