test: forward port cpp test for 4.14.2 #11054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this fix #11033? |
Leonidas-from-XIV
requested changes
Oct 30, 2024
|
@anmonteiro No, this fixes the compilation of a cram test on OCaml <5. The original PR (#10962) was tested on 5.1.1 but backporting the fix to 3.16.x (which uses 4.14.2) revealed that there's a compilation error. |
Leonidas-from-XIV
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks, looks good. And thanks @kit-ty-kate for pointing out the fix in #11051.
Signed-off-by: Etienne Marais <dev@maiste.fr>
Co-authored-by: Marek Kubica <marek@xivilization.net> Signed-off-by: Etienne Marais <dev@maiste.fr>
Leonidas-from-XIV
force-pushed
the
fix/forward-port-4.14
branch
from
afcb886 to
9c713d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forward ports some changes we have found while releasing 3.16.1. There was an issue with the order of the headers: it was ereasing some informations and make the test crash with
ocaml.4.14.2.