fix: Do not depend on dune in dune-project in dune init template
#11129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
force-pushed
the
dune-init-dune-dep
branch
from
c355ce6
to
55f5607
Compare
maiste
approved these changes
Nov 18, 2024
gridbugs
approved these changes
Nov 19, 2024
maiste
force-pushed
the
dune-init-dune-dep
branch
from
55f5607
to
4756e94
Compare
Dune automatically adds the right constraint anyway, with the right version constraint. All Dune project implicitely depend on Dune anyway and the tests show that the opam files correctly include Dune. This helps with ocaml#11106 but also avoids the bug where Dune couldn't solve a package because it depended on Dune and in the Dune Package Management we explicitely remove the dependency. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
dune-init-dune-dep
branch
from
4756e94
to
aef9a62
Compare
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
added a commit
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune automatically adds the right constraint anyway, with the right version constraint. All Dune project implicitely depend on Dune anyway and the tests show that the opam files correctly include Dune.
This helps with #11106 but also would have avoided triggering the bug in #11103 when the project is created with
dune init proj.