[3.17] backport 11204 - remove errors message from dune subst with empty dir
#11216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a CI error, but looks unrelated. |
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Signed-off-by: Etienne Marais <dev@maiste.fr>
maiste
force-pushed
the
backport-11204
branch
from
0c2bf5d to
b4f1691
Compare
|
Your backport seemed to pass the CI. I have rebased, and we will see if the error is still here. If it does pass, I will merge this PR and prepare the release. EDIT: the only part that does not succeed is the coverage. I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for the 3.17.1 release.