Remove globs from odoc #2434
Merged
Remove globs from odoc #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the list of odocs per package and library was obtained by globing the odocs target dir. That's a bit dodgy because it relied on all the rules that generated such odocs to fire. The new code just simply generates the list of odocs from the sources without making any assumptions. Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the list of odocs per package and library was obtained by
globing the odocs target dir. That's a bit dodgy because it relied on
all the rules that generated such odocs to fire. The new code just
simply generates the list of odocs from the sources without making any
assumptions.