Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install vendored packages #3074

Merged
1 commit merged into from Feb 3, 2020
Merged

Do not install vendored packages #3074

1 commit merged into from Feb 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2020

/cc @fpottier

@rgrinberg
Copy link
Member

What happens when one installs a public library that depends on some vendored library?

@ghost
Copy link
Author

ghost commented Feb 3, 2020

Right now, dune will install the public library but it won't be usable. I guess we should produce an error similar to when a public library depends on a private library.

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's improve the error later.

@ghost ghost merged commit 79a27e5 into ocaml:master Feb 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants