Add pps field to toplevel stanza, use ppx rewriters in utop #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanieyou
changed the title
ghost
suggested changes
Apr 7, 2020
test/blackbox-tests/test-cases/toplevel-stanza/preprocessors/fooppx.ml
Outdated
Show resolved
Hide resolved
|
Just one last thing: could you sign your commits (as explained in the CONTRIBUTING.md file)? Then this is ready to merge! |
stephanieyou
force-pushed
the
toplevel-ppx
branch
from
85bd8a4 to
afe8f77
Compare
stephanieyou
requested review from
aalekseyev,
ejgallego,
emillon,
fpottier,
nojb and
rgrinberg
as code owners
|
I'm breaking something (or many things) with git... Please ignore while I try to fix 😅Sorry |
stephanieyou
force-pushed
the
toplevel-ppx
branch
from
38543b8 to
ab3e2eb
Compare
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
…nto toplevel-ppx
stephanieyou
force-pushed
the
toplevel-ppx
branch
from
ab3e2eb to
974b525
Compare
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
rgrinberg
reviewed
Apr 7, 2020
rgrinberg
reviewed
Apr 7, 2020
|
Could you also update the documentation for the toplevel stanza? It's in dune-files.rst. |
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
…nto toplevel-ppx
stephanieyou
force-pushed
the
toplevel-ppx
branch
from
f67a697 to
7642bec
Compare
Signed-off-by: Stephanie You <youstephanie98@gmail.com>
|
Just updated the documentation! |
rgrinberg
reviewed
Apr 7, 2020
…or toplevel pps Signed-off-by: Stephanie You <youstephanie98@gmail.com>
|
Thanks for you efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346
If directory contains a ppx rewriter, makes the ppx extension usable in dune utop. Also allows pps field in toplevel stanzas.