Document re_export field #3661
Merged
Document re_export field #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ocaml#3657 Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ghost
reviewed
Jul 30, 2020
ghost
reviewed
Jul 30, 2020
doc/dune-files.rst
Outdated
| transitive dependencies being available to users of a library. For example, if | ||
| we define a library ``core``, that extends ``core_kernel``, we'd like users of | ||
| ``core`` to immediately have ``core_kernel`` available as well. To do this, we | ||
| must define the dependency on ``core_kernel`` as re-exported: |
There was a problem hiding this comment.
That's not actually true though. We don't want Core to re-export Core_kernel. Core supersedes Core_kernel, so users of Core should stick to Core.
There was a problem hiding this comment.
Yeah, that's true. I'll stick to some dummy names to avoid confusing the user.
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ghost
reviewed
Jul 30, 2020
ghost
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3657