-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep rules marked promote until-clean with -p #5956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Jul 21, 2022
christinerose
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to wrap dune-lang
in monospace
Closes ocaml#4401 Signed-off-by: Etienne Millon <me@emillon.org>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com> Signed-off-by: Etienne Millon <me@emillon.org>
rgrinberg
added a commit
that referenced
this pull request
Aug 26, 2023
Bug #4401 was `(promote until-clean)` rules being incorrectly ignored by `--ignore-promoted-rules`. PR #5956 fixed it but only made the fix available to newer projects. This means that projects must update their dune versions before users can actually build this project without being affected by this bug. Since this bug fix doesn't have much the potential to break anything, we make the fix available to all versions. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 82b639c6-a417-4ae8-8cd2-fae02849ea83 -->
rgrinberg
added a commit
that referenced
this pull request
Aug 26, 2023
Bug #4401 was `(promote until-clean)` rules being incorrectly ignored by `--ignore-promoted-rules`. PR #5956 fixed it but only made the fix available to newer projects. This means that projects must update their dune versions before users can actually build this project without being affected by this bug. Since this bug fix doesn't have much the potential to break anything, we make the fix available to all versions. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 82b639c6-a417-4ae8-8cd2-fae02849ea83 -->
rgrinberg
added a commit
that referenced
this pull request
Aug 26, 2023
Bug #4401 was `(promote until-clean)` rules being incorrectly ignored by `--ignore-promoted-rules`. PR #5956 fixed it but only made the fix available to newer projects. This means that projects must update their dune versions before users can actually build this project without being affected by this bug. Since this bug fix doesn't have much the potential to break anything, we make the fix available to all versions. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 82b639c6-a417-4ae8-8cd2-fae02849ea83 -->
rgrinberg
added a commit
to rgrinberg/sedlex
that referenced
this pull request
Aug 26, 2023
`(promote (until-clean))` is ignored when `--ignore-promoted-rules` is passed in later versions of dune. See ocaml/dune#4401 ocaml/dune#5956 Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
toots
pushed a commit
to ocaml-community/sedlex
that referenced
this pull request
Aug 26, 2023
`(promote (until-clean))` is ignored when `--ignore-promoted-rules` is passed in later versions of dune. See ocaml/dune#4401 ocaml/dune#5956 Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Sep 21, 2023
This extends ocaml#5956 to all versions of `(lang dune)`, since this is a property of the CLI. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Sep 21, 2023
This extends ocaml#5956 to all versions of `(lang dune)`, since this is a property of the CLI. Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4401