-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printing internal libs with the command "dune describe external-lib-deps" #6370
Conversation
4f62fc7
to
12b2716
Compare
It would really help understanding your fix if you could give an example that first shows the produced output and the expected output, and explains why the expected output should be the right one. |
This PR refers to #6045 |
This was the print before.
and the right one is
This is because Refer to the tests that I added. |
Is it possible to have this PR for dune 3.6 ? |
a5a7ee6
to
bc3b000
Compare
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/dune-project
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/lib/dune
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/run.t
Outdated
Show resolved
Hide resolved
e46e743
to
5758050
Compare
When the internal libs are added as dependency by another dune library or dune executable. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
b428c19
to
99c7002
Compare
Thanks! |
When the internal libs are added as dependency by another dune library or dune executable, those are printed.