Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing internal libs with the command "dune describe external-lib-deps" #6370

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

moyodiallo
Copy link
Collaborator

When the internal libs are added as dependency by another dune library or dune executable, those are printed.

@moyodiallo moyodiallo force-pushed the fix-bug-external-lib-dpes branch from 4f62fc7 to 12b2716 Compare November 1, 2022 13:52
@esope
Copy link
Collaborator

esope commented Nov 2, 2022

It would really help understanding your fix if you could give an example that first shows the produced output and the expected output, and explains why the expected output should be the right one.
I currently have no idea of what the intended semantics for external-lib-deps should be...

@moyodiallo
Copy link
Collaborator Author

dune describe external-lib-deps is supposed to print only external libraries by dir which contain a dune file.
I simplify the test that I added with more understanding. Feel free to reformulate it.

This PR refers to #6045

@moyodiallo
Copy link
Collaborator Author

This was the print before.

(default
 ((.
   ((a________ required)
    (inter_lib required)))
  (lib ((a________ required)))))

and the right one is

(default
 ((. ((a________ required)))
  (lib ((a________ required)))))

This is because inter_lib is an internal lib.

Refer to the tests that I added.

@moyodiallo
Copy link
Collaborator Author

Is it possible to have this PR for dune 3.6 ?
There's a need for ocurrent/opam-dune-lint#46.

@emillon

@emillon emillon added this to the 3.6.0 milestone Nov 3, 2022
@rgrinberg rgrinberg requested a review from emillon November 3, 2022 15:49
@moyodiallo moyodiallo force-pushed the fix-bug-external-lib-dpes branch from a5a7ee6 to bc3b000 Compare November 3, 2022 16:22
@moyodiallo moyodiallo force-pushed the fix-bug-external-lib-dpes branch from e46e743 to 5758050 Compare November 8, 2022 16:02
When the internal libs are added as dependency by another dune library
or dune executable.

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
@emillon emillon force-pushed the fix-bug-external-lib-dpes branch from b428c19 to 99c7002 Compare November 14, 2022 09:02
@emillon
Copy link
Collaborator

emillon commented Nov 14, 2022

Thanks!

@emillon emillon merged commit b907d03 into ocaml:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants