-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nix): use nix-overlays for the slim devShell #6546
chore(nix): use nix-overlays for the slim devShell #6546
Conversation
Another note: I don't know if anyone else is using the slim shell other than myself (added in #6327). |
This is (unfortunately) intentional since we need to build dev deps with the new dune in case we break how things are installed. Dune has done this in the past. |
That's fair. My proposal here is that users of the |
I think that is fine to have and is essentially what we have for Coq today too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, just needs a rebase.
Note that running opam2nix is the cause of the slowdown. The issue is that every change to the source requires to rebuild the downstream packages. What would be nice is to have a middle ground environment that uses the dune from opam to build all the dev deps.
f947f89
to
7fd2da7
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
7fd2da7
to
6ba768b
Compare
Rebased |
* main: (58 commits) test: formatting of alternative dune files (ocaml#6567) refactor: remove Modules.is_empty (ocaml#6564) refactor: module kinds (ocaml#6562) refactor(coq): resolve lack of coqc properly Cache file contents in action builder by name. (ocaml#6555) fix: re-enable dune on older macos sdk's (ocaml#6515) fix: do not hide lib interface module (ocaml#6549) test: remove pkg-config output for reproducibility (ocaml#6543) melange: add test for ocaml flags (ocaml#6548) fix: improve virtual library error messages test: virtual library and impl locations test: alias module regression (ocaml#6544) refactor(merlin): dump config sub command (ocaml#6547) refactor: simplify merlin (ocaml#6508) chore(nix): use nix-overlays for the slim devShell (ocaml#6546) fix: module compilation rule env (ocaml#6527) chore: update nix (ocaml#6536) fix: merlin rules with pp's (ocaml#6474) Call [Dune_util.Log.init] as soon as possible (ocaml#6542) refactor: speed up stdlib build (ocaml#6524) ...
I noticed a few problems with the regular shell:
nixpkgs
input doesn't give me editor completion on the slim shell, but usingnix-overlays
as the input fixes it for meSteps to reproduce:
Signed-off-by: Antonio Nuno Monteiro anmonteiro@gmail.com