New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notty Take 2 #6654

Merged

rgrinberg merged 3 commits into main from notty2

Dec 16, 2022

Member

rgrinberg commented Dec 8, 2022

No description provided.

Alizter reviewed

View reviewed changes

otherlibs/stdune/ansi_color.mli Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

src/dune_console/dune_console.ml Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

src/dune_console/notty_console.ml Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

otherlibs/stdune/ansi_color.ml Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

otherlibs/stdune/ansi_color.ml Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

otherlibs/stdune/ansi_color.ml Outdated Show resolved Hide resolved

rgrinberg commented

View reviewed changes

otherlibs/stdune/ansi_color.ml Outdated Show resolved Hide resolved

Alizter mentioned this pull request

refactor(ansi_color): Make Ansi_color.t into a variant #6688

Merged

Alizter force-pushed the notty2 branch from 9d6dd6d to 0a690c2 Compare

December 13, 2022 07:56

Alizter added a commit to Alizter/dune that referenced this pull request


          refactor(scheduler): cleanup scheduler display api

30b5d63

We cleanup the Display API in the Scheduler by consolidating the types
of display. This allows us to tweak the data of `Display.t` in the
future (as in ocaml#6654) without having to update other parts of the
code. It should also make the code read better.

<!-- ps-id: c8841d58-c436-46b8-849a-d4e42c977af2 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter mentioned this pull request

refactor(scheduler): cleanup scheduler display api #6689

Closed

Collaborator

Alizter commented Dec 13, 2022

I've rebased and squashed some of the other commits. The independent changes have been siphoned into their own PRs for review. This still needs a bit more work to make sure there are no regressions for users. Also we need to address the failures in the CI.

Alizter added a commit to Alizter/dune that referenced this pull request


          refactor(scheduler): cleanup scheduler display api

795cb60

We cleanup the Display API in the Scheduler by consolidating the types
of display. This allows us to tweak the data of `Display.t` in the
future (as in ocaml#6654) without having to update other parts of the
code. It should also make the code read better.

<!-- ps-id: c8841d58-c436-46b8-849a-d4e42c977af2 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter force-pushed the notty2 branch 7 times, most recently from 4c07167 to 2f8d584 Compare

December 14, 2022 23:38

rgrinberg force-pushed the notty2 branch 3 times, most recently from a367d94 to a0f7faf Compare

December 15, 2022 21:37

Alizter force-pushed the notty2 branch from a0f7faf to d374711 Compare

December 15, 2022 21:54

rgrinberg marked this pull request as ready for review

December 15, 2022 22:32

rgrinberg force-pushed the notty2 branch from fbc3d8b to b5ac6c7 Compare

December 15, 2022 22:45

rgrinberg added 3 commits

December 15, 2022 23:57


          chore: vendor notty

448e3ac

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>


          feature: basic tui

ffbcf66

We add a basic Terminal User Interface (TUI) using NoTTY as a
backend.

Co-authored-by: Ali Caglayan <alizter@gmail.com>

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>


          fix(notty): remove C flags

c6494d2

These flags should be set globally for the project

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

Alizter force-pushed the notty2 branch from b5ac6c7 to c6494d2 Compare

December 15, 2022 22:58

rgrinberg merged commit 388eed0 into main

rgrinberg deleted the notty2 branch

December 16, 2022 00:12

rgrinberg added a commit that referenced this pull request


          chore: update CHANGES

70931f7

accidental fix of #6700 in #6654

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: 79cbc1f4-9228-4d80-83eb-e921ceb3381f

rgrinberg mentioned this pull request

chore: update CHANGES #6743

Merged

rgrinberg linked an issue

that may be closed by this pull request

Missing newline in "dune exec" #6700

Closed

rgrinberg added a commit that referenced this pull request


          chore: update CHANGES (#6743)

3ae4da3

accidental fix of #6700 in #6654

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

efce75d

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

70bac5f

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

e0a81aa

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

0fdc30b

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

bce7740

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

36b6076

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

rgrinberg pushed a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

a4ccd72

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

3368e07

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

84c34fc

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Alizter added a commit to Alizter/dune that referenced this pull request


          dune_console: reorganize threading logic

b09786d

We reorganize the threading logic for threaded dune_console
backends. We also add stages for things like handling user events
which will be useful later for the NoTTY TUI implementation.

This also fixes a bug ocaml#6654 where a new line after dune exec was
missing.

<!-- ps-id: e6448a4b-f084-4ce3-9ff3-81f5b5e1a5d4 -->

Signed-off-by: Ali Caglayan <alizter@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet