refactor: extract modules from Install_rules #7590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Package_paths` and `Stanzas_to_entries` are made top level in `dune_rules`. Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
stanzas-to-entries
branch
from
1a63375 to
a2994a1
Compare
|
It's a bit of a shame to make so many additional functions public. Can we stick to exporting only what is being used? |
What module are you thinking of specifically? |
|
Yes, Package_paths is the offender. It has a lot of functions that I wouldn't want anyone using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package_pathsandStanzas_to_entriesare made top level indune_rules, and the modules related to installation are moved to ainstallsubdirectory.