tests: use [tail] instead of [wait] to block on a process finishing #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmwhite
changed the title
pmwhite
changed the title
pmwhite
force-pushed
the
use-tail-instead-of-wait
branch
from
a5efde7 to
2887a32
Compare
|
Hi, see my PR solving the same issue: #8201 The reason is due to a bug in bash which aliases the pid causing wait to lose track of its children. |
pmwhite
force-pushed
the
use-tail-instead-of-wait
branch
from
2887a32 to
b8d26ff
Compare
I'm not entirely sure why, but when I run [dune runtest] on the repository, I get the following error: ./helpers.sh: line 25: wait: pid 123456 is not a child of this shell My hypothesis is that the command that starts dune is run from within a different sub-shell than the command that stops it. What confuses me is that this error doesn't show up in CI jobs; maybe it's because of differences in the version of bash on my machine and the CI machine? In any case, I think using [tail] is more robust to changes in the structure of the scripts, so even if I could fix my environment to make the tests pass, I think this is a good change. Signed-off-by: Philip White <code@trailingwhite.space>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why, but when I run
dune runteston the repository, I get the following error:My hypothesis is that the command that starts dune is run from within a different sub-shell than the command that stops it. What confuses me is that this error doesn't show up in CI jobs; maybe it's because of differences in the version of bash on my machine and the CI machine? In any case, I think using
tailis more robust to changes in the structure of the scripts, so even if I could fix my environment to make the tests pass, I think this is a good change.Signed-off-by: Philip White code@trailingwhite.space