-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: serialize and deserialize RPC error messages #8411
test: serialize and deserialize RPC error messages #8411
Conversation
@rgrinberg I think the correct fix for this would be to make |
63281ae
to
8f9d38f
Compare
8f9d38f
to
2b46350
Compare
692876c
to
bac10c3
Compare
@rgrinberg I've pushed another test which shows how location printing is kind of funny. I need some help scrubbing the output however. |
bac10c3
to
b55b2e5
Compare
b55b2e5
to
fd58a5d
Compare
fd58a5d
to
4c93ceb
Compare
@rgrinberg I've also included dyn serialisation so we can more finely compare the Pp structure that has been serialised. |
4c93ceb
to
77ce937
Compare
@rgrinberg I've moved the tests now and added yet another example of an error message that changes. All these examples will be fixed by my upcoming PR. |
a74d86f
to
8c09cc7
Compare
We demonstrate a bug with how error messages are serialized. Currently there are two "Error:" prefixes after serializing and deserializing. This is because the prefix hasn't been stripped in the initial serialization. We should strip the prefix since the severity information is recorded elsewhere in the diagnostic data. Signed-off-by: Ali Caglayan <alizter@gmail.com>
8c09cc7
to
3c924a3
Compare
We demonstrate a bug with how error messages are serialized. Currently there are two "Error:" prefixes after serializing and deserializing. This is because the prefix hasn't been stripped in the initial serialization. We should strip the prefix since the severity information is recorded elsewhere in the diagnostic data.