Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move file contents memoization to [Build_system] #9550

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Dec 20, 2023

and remove it from the rules

Continuation of the splitting of #9132

Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a couple of suggestions.

and remove it from the rules

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: cdfe9456-4a40-46ea-8100-f6b186740475 -->
@rgrinberg rgrinberg force-pushed the ps/rr/refactor__move_file_contents_memoization_to__build_system_ branch from 248b2c0 to 915dea3 Compare December 20, 2023 18:14
@rgrinberg rgrinberg merged commit 35872f7 into main Dec 20, 2023
26 of 27 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor__move_file_contents_memoization_to__build_system_ branch December 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants