refactor: switch to new API for recording deps #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: d4bf94f5-7671-4781-ab35-dcbc204bf72b -->
rgrinberg
force-pushed
the
ps/rr/refactor__switch_to_new_api_for_recording_deps
branch
from
2bf2eba to
60b2a3c
Compare
snowleopard
approved these changes
Dec 20, 2023
|
There's one last PR i'm working on which makes |
|
Cool, almost done :) |
rgrinberg
deleted the
ps/rr/refactor__switch_to_new_api_for_recording_deps
branch
Alizter
reviewed
Apr 20, 2024
Comment on lines
44
to
+46
| let contents p = | ||
| of_thunk | ||
| { f = | ||
| (fun _mode -> | ||
| let open Memo.O in | ||
| let+ x = Build_system.read_file p in | ||
| x, Dep.Map.empty) | ||
| } | ||
| let* () = Dep.file p |> Dep.Set.singleton |> Build_system.record_deps in | ||
| of_memo (Build_system.read_file p) |
There was a problem hiding this comment.
@rgrinberg This wasn't happening before and Coq rules were relying on it. Removing the recording of the dep fixes #10149.
There was a problem hiding this comment.
Huh, indeed! Good catch.
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Apr 20, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
1 task
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Apr 20, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Apr 20, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Apr 20, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Leonidas-from-XIV
pushed a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Apr 22, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
emillon
pushed a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Apr 23, 2024
PR ocaml#9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue ocaml#10149 to appear. This PR fixes ocaml#10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com>
emillon
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Add reproduction test case for #10149. Signed-off-by: Rodolphe Lepigre <rodolphe@bedrocksystems.com> Signed-off-by: Ali Caglayan <alizter@gmail.com> * stop recording deps in Action_builder.contents PR #9552 changed the semantics of Action_builder.contents so that it records a dependency. The Coq rules were relying on the previous behaviour of not recording a dependency in order to generate a build plan. This caused issue #10149 to appear. This PR fixes #10149 by removing the dependency being recorded in Action_builder.contents matching the previous semantics. Signed-off-by: Ali Caglayan <alizter@gmail.com> --------- Signed-off-by: Rodolphe Lepigre <rodolphe@bedrocksystems.com> Signed-off-by: Ali Caglayan <alizter@gmail.com> Co-authored-by: Rodolphe Lepigre <rodolphe@bedrocksystems.com> Co-authored-by: Ali Caglayan <alizter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the splitting of #9132