Add examples for Re.split function #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build is failing due to the dependency on |
bbatsov
reviewed
Apr 23, 2023
lib/core.mli
Outdated
| @@ -280,6 +280,22 @@ val split : ?pos:int -> ?len:int -> re -> string -> string list | |||
| # Re.split ~pos:3 regex "1,2,3,4. Commas go brrr.";; | |||
| - : string list = ["3"; "4. Commas go brrr."] | |||
| ]} | |||
|
|
|||
| Be careful when using [split] with zero-length patterns like [eol], [bow], | |||
There was a problem hiding this comment.
Perhaps you should explain what to be careful about, as it's kind of vague even with the examples. I get the general idea, but I think this could be explained in more detail.
There was a problem hiding this comment.
I added more details in the latest commit.
mooreryan
force-pushed
the
add-split-examples
branch
from
dddd801
to
528a3fe
Compare
|
Any interest in this PR? If so I could resolve the conflicts, if not, I will close it. |
|
Sure, I think this PR is useful. Ping me when it's ready and I'll merge. |
mooreryan
force-pushed
the
add-split-examples
branch
from
ac26ae9
to
0edc5f9
Compare
|
Thanks @rgrinberg, I rebased, and added corresponding examples to the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few examples of using zero-length patterns as inputs to Re.split. Examples are taken from the test suite. Related to #119 and #120.
I know it is an old issues (this one: #119), but I also tried to use the
eolas input forsplitin the past. So, I took a couple of the test cases and added them to the examples forRe.split.