Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune-project: add lower bound on ocaml #229

Merged
merged 2 commits into from
Mar 9, 2021
Merged

dune-project: add lower bound on ocaml #229

merged 2 commits into from
Mar 9, 2021

Conversation

mseri
Copy link
Member

@mseri mseri commented Mar 9, 2021

The code uses String.split_on_char which was introduced in 4.04.
Should I also regenerate the opam file?

The code uses String.split_on_char which was introduced in 4.04
@nojb
Copy link
Contributor

nojb commented Mar 9, 2021

Thanks! I belive the omd.opam file (which is auto-generated when you do dune build) also needs to be updated.

@nojb
Copy link
Contributor

nojb commented Mar 9, 2021

Should I also regenerate the opam file?

Yes, please :)

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Copy link
Member Author

mseri commented Mar 9, 2021

Done :)

@nojb nojb merged commit 885eda4 into ocaml:master Mar 9, 2021
@nojb
Copy link
Contributor

nojb commented Mar 9, 2021

Thanks!

mseri pushed a commit to ocaml/opam-repository that referenced this pull request Jun 25, 2021
CHANGES:

- Clean up AST representation (ocaml/omd#229, @sonologico)

- Restore table of contents generation functionality (ocaml/omd#240, @sonologico)

- Fix parsing of <...>-style links and inline code parsing (ocaml/omd#233, @SquidDev)

- Fix handing of the nonbreaking whitespace character, ASCII code 160 (ocaml/omd#247,
  @shonfeder)

- Downgrade dune requirements to 2.0 (@nobj)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants