Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin camlp-streams #275

Closed
wants to merge 1 commit into from
Closed

pin camlp-streams #275

wants to merge 1 commit into from

Conversation

tatchi
Copy link
Collaborator

@tatchi tatchi commented Jul 28, 2022

I created this branch to verify that ocaml/camlp-streams#8 fixes our build issue. I thought I would open a PR in case you would like to merge it as a temporary solution.

Feel free to close it if you prefer to wait for a proper solution.

@tatchi tatchi requested a review from shonfeder July 28, 2022 16:34
@shonfeder
Copy link
Collaborator

Thank you for trying this out and showing ocamlp-streams that this does indeed resolve the problem. For the purposes of our work on the new version of OMD, I think we can safely (and with less overhead) just bump our minimum supported ocaml version to 4.05 (also suggested in ocaml/camlp-streams#7 (comment)). See #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants