Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-release Markup.ml 1.0.0 #17500

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Re-release Markup.ml 1.0.0 #17500

merged 1 commit into from
Oct 27, 2020

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Oct 25, 2020

I'd like to amend the Markup 1.0.0 release from last week (#17431) with a new breaking change. cc @dmbaturin.

Changelog:

Breaking

Bugs fixed

@camelus
Copy link
Contributor

camelus commented Oct 25, 2020

Commit: bed0617

A pull request by opam-seasoned @aantron.

☀️ All lint checks passed bed0617
  • These packages passed lint tests: markup.1.0.0-1, markup.1.0.0

🌤️ Installability check (+0)
  • these releases are not installable anymore (1): markup.1.0.0
  • new installable packages (1): markup.1.0.0-1

@dmbaturin
Copy link
Contributor

@aantron Your opam file has a wrong checksum.

You have this:

url {
  src: "https://github.com/aantron/markup.ml/archive/1.0.0.tar.gz"
  checksum: "md5=d41d8cd98f00b204e9800998ecf8427e"
}

But actual tarball has:

$  wget https://github.com/aantron/markup.ml/archive/1.0.0.tar.gz
$ md5sum ./1.0.0.tar.gz 
d9964f196850af5507b66b7a141bff11  ./1.0.0.tar.gz

@aantron
Copy link
Contributor Author

aantron commented Oct 27, 2020

@dmbaturin Thanks, fixed. Was a firewall issue.

@mseri
Copy link
Member

mseri commented Oct 27, 2020

Do we have to re-release? There have been a lot of complaints about mutability of releases, is there no other option in this case?

I will also ping @kit-ty-kate for an opinion

@avsm
Copy link
Member

avsm commented Oct 27, 2020

If this is re-released, please bump the epoch (so markup.1.0.0-1) to indicate the checksum has changed for a known reason. This seems like a reasonable convention in the event that upstream really wants a re-release.

@aantron
Copy link
Contributor Author

aantron commented Oct 27, 2020

I changed the version number to 1.0.0-1.

I still think this is unnecessary in this particular case, as a fast merge is likely to avoid causing problems for downstream projects.

@avsm
Copy link
Member

avsm commented Oct 27, 2020

I still think this is unnecessary in this particular case, as a fast merge is likely to avoid causing problems

Unfortunately, we can't predict when the people using opam-repository take their snapshots for their own deployments, so this hasn't been true in the past. (I caused great drama in the Tezos downstream opam-repo with a re-release of uri last year, for instance).

@dmbaturin
Copy link
Contributor

How should I specify that version as a dependency? Will markup { >= 1.0.0-1 } work as expected?

@avsm
Copy link
Member

avsm commented Oct 27, 2020

Yes, if you add quotes around the version.

@kit-ty-kate
Copy link
Member

Since it is already changing versions, could it be 1.1.0 or 2.0.0 to reflect the API break?
Also the tag changed. Could you add available: false to the markup.1.0.0 package?

@aantron
Copy link
Contributor Author

aantron commented Oct 27, 2020

I created a markup.1.0.0-1 directory with the new opam file, reverted the previous markup.1.0.0/opam, and added available: false to it.

@mseri
Copy link
Member

mseri commented Oct 27, 2020

Thanks!

@mseri mseri merged commit 6f65836 into ocaml:master Oct 27, 2020
@aantron
Copy link
Contributor Author

aantron commented Oct 28, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants