[new release] opam-dune-lint (0.2) #19023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
force-pushed
the
release-opam-dune-lint-v0.2
branch
from
19edb21 to
9ab0fac
Compare
CHANGES: - Cope with missing `(depends ...)` in `dune-project` (@talex5 ocurrent/opam-dune-lint#33). We tried to add the missing packages to an existing depends field, but if there wasn't one at all then we did nothing. - Use quoted versions in the fix suggestion string (@tmcgilchrist ocurrent/opam-dune-lint#32). Makes copy-and-paste easier for people using it via a web UI. - Support older versions of OCaml back to 4.10 (@tmcgilchrist ocurrent/opam-dune-lint#31). - Ignore dependencies on sub-packages (@dra27 ocurrent/opam-dune-lint#27). Library `foo` may depend on library `foo.bar` but this cannot introduce an opam dependency on `foo` in `foo.opam`. - Require opam libraries compatible with the client (@dra27 ocurrent/opam-dune-lint#26). - Add support for multiple dependency clauses for the same package (@kit-ty-kate ocurrent/opam-dune-lint#25). - Upgrade to dune-private-libs 2.8.0 (@kit-ty-kate ocurrent/opam-dune-lint#20). - Remove dependency on ocamlfind, as we don't use it for anything now (@talex5 ocurrent/opam-dune-lint#18).
talex5
force-pushed
the
release-opam-dune-lint-v0.2
branch
from
9ab0fac to
a409905
Compare
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure dune and opam dependencies are consistent
CHANGES:
Cope with missing
(depends ...)indune-project(@talex5 Cope with missing depends in dune-project ocurrent/opam-dune-lint#33). We tried to add the missing packages to an existing depends field, but if there wasn't one at all then we did nothing.Use quoted versions in the fix suggestion string (@tmcgilchrist Add quoted fix suggestion string. ocurrent/opam-dune-lint#32). Makes copy-and-paste easier for people using it via a web UI.
Support older versions of OCaml back to 4.10 (@tmcgilchrist Support older versions of OCaml back to 4.10. ocurrent/opam-dune-lint#31).
Ignore dependencies on sub-packages (@dra27 Ignore dependencies on sub-packages ocurrent/opam-dune-lint#27). Library
foomay depend on libraryfoo.barbut this cannot introduce an opam dependency onfooinfoo.opam.Require opam libraries compatible with the client (@dra27 Require opam libraries compatible with the client ocurrent/opam-dune-lint#26).
Add support for multiple dependency clauses for the same package (@kit-ty-kate Add support for multiple dependency clauses for the same package ocurrent/opam-dune-lint#25).
Upgrade to dune-private-libs 2.8.0 (@kit-ty-kate Upgrade to dune-private-libs 2.8.0 ocurrent/opam-dune-lint#20).
Remove dependency on ocamlfind, as we don't use it for anything now (@talex5 Remove dependency on ocamlfind ocurrent/opam-dune-lint#18).