-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing license field on the OCaml compiler packages #19327
Conversation
The presence of this field will be checked by opam lint starting with opam 2.2.0 Partly related to ocaml/opam-repository#19327 and ocaml/opam#4598
@@ -1,6 +1,7 @@ | |||
opam-version: "2.0" | |||
synopsis: "Official 4.03.0 release" | |||
maintainer: "platform@lists.ocaml.org" | |||
license: "QPL-1.0 AND LGPL-2.1-or-later WITH OCaml-LGPL-linking-exception" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.03 was the first release to be distributed under the LGPL with linkink exceptions and not QPL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure? According to ocaml/ocaml@7fc2d21 it was only done in 4.04.0. The 4.03 branch has it technically but it was only added after the release of 4.03.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, and according to ocaml/ocaml@0ca4d6a74 the plan was to update the license for 4.03 . Keeping the QPL license is probably more precise indeed. Sorry for the noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @kit-ty-kate : 4.03.0 was released before the switch to LGPL.
Normalizing the compiler opam files is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kit-ty-kate for taking care of this! I checked the main packages and it looks good to me. Didn't check all the variant packages, but I trust you.
Side note: the line
authors: "Xavier Leroy and many contributors"
that appears in some of the opam
files doesn't give enough justice to the "many contributors", but that's unrelated to this PR.
cc @Octachron
Partly solves #18343