Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] tls, tls-mirage, tls-eio and tls-async (0.15.4) #22175

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Sep 27, 2022

Transport Layer Security purely in OCaml

CHANGES:

@hannesm
Copy link
Member Author

hannesm commented Sep 27, 2022

CI looks good to me to be merged, apart from //cc @talex5

#=== ERROR while compiling tls-eio.0.15.4 =====================================#
# context              2.1.2 | macos/x86_64 | ocaml.5.0.0 | pinned(https://github.com/mirleft/ocaml-tls/releases/download/v0.15.4/tls-0.15.4.tbz)
# path                 ~/.opam/default/.opam-switch/build/tls-eio.0.15.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p tls-eio -j 11
# exit-code            1
# env-file             ~/.opam/log/tls-eio-66074-df0c8c.env
# output-file          ~/.opam/log/tls-eio-66074-df0c8c.out
### output ###
# File "eio/tests/tls_eio.md", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/eio/tests/tls_eio.md _build/default/eio/tests/.mdx/tls_eio.md.corrected
# diff --git a/_build/default/eio/tests/tls_eio.md b/_build/default/eio/tests/.mdx/tls_eio.md.corrected
# index dace2d7..0e7fbb9 100644
# --- a/_build/default/eio/tests/tls_eio.md
# +++ b/_build/default/eio/tests/.mdx/tls_eio.md.corrected
# @@ -106,11 +106,5 @@ let serve_ssl ~config server_s callback =
#         test_client ~net ("127.0.0.1", "4433")
#      )
#    ;;
# -+server -> start @ tcp:127.0.0.1:4433
# -+server -> connect
# -+handler accepted
# -+handler + GET / HTTP/1.1
# -+client <- GET
# -+client done.
# -- : unit = ()
# +Exception: Eio_luv.Luv_error(EPERM) (* operation not permitted *)
# 

but that may be another instance of ocaml/opam#4389

@talex5
Copy link
Contributor

talex5 commented Sep 27, 2022

Yes, it's the mac sandbox again. Should be fine to ignore it.

Eio does come with a mock network that can be used for tests. We could switch to that for the next release, since we only care about testing TLS, not the OS's network support.

@mseri mseri merged commit 5388103 into ocaml:master Sep 28, 2022
@mseri
Copy link
Member

mseri commented Sep 28, 2022

Thanks

@hannesm hannesm deleted the release-tls-v0.15.4 branch October 12, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants