Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] irmin project (3.4.3) #22321

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Conversation

icristescu
Copy link
Contributor

@icristescu icristescu commented Oct 19, 2022

CHANGES:

Fixed

…ils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.4.3)

CHANGES:

### Fixed

- **irmin-pack**
  - Fix read-only opening flags of mapping for read-only opening of stores that
    do not have read-write rights on the files. (mirage/irmin#2121, @Ngoguey42)
@icristescu icristescu changed the title [new release] ppx_irmin, libirmin, irmin, irmin-tezos, irmin-tezos-utils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.4.3) [new release] irmin project (3.4.3) Oct 19, 2022
@kit-ty-kate
Copy link
Member

Why also adding this restrictions to the other packages? Only the tests for those were failing and this can be ignored or disabled at test level

Co-authored-by: Kate <kit.ty.kate@disroot.org>
@icristescu
Copy link
Contributor Author

@kit-ty-kate I moved the os restriction on the tests only.

Some tests for irmin-https are flaky, they could be the cause of the timeouts in the CI.
@icristescu
Copy link
Contributor Author

The error in the CI seems to me unrelated to irmin, so maybe this can be merged? Let me know if you think I need to fix something on irmin side. Thanks!

#=== ERROR while compiling h2.0.7.0 ===========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-variants.5.0.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.0/.opam-switch/build/h2.0.7.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p h2 -j 31
# exit-code            1
# env-file             ~/.opam/log/h2-7-2ee6fa.env
# output-file          ~/.opam/log/h2-7-2ee6fa.out
### output ###
# (cd _build/default && /home/opam/.opam/5.0/bin/ocamlc.opt -w -40 -g -bin-annot -I lib/.h2.objs/byte -I /home/opam/.opam/5.0/lib/angstrom -I /home/opam/.opam/5.0/lib/base64 -I /home/opam/.opam/5.0/lib/bigstringaf -I /home/opam/.opam/5.0/lib/faraday -I /home/opam/.opam/5.0/lib/hpack -I /home/opam/.opam/5.0/lib/httpaf -I /home/opam/.opam/5.0/lib/psq -I /home/opam/.opam/5.0/lib/result -I /home/opam/.opam/5.0/lib/seq -no-alias-deps -open H2__ -o lib/.h2.objs/byte/h2__Scheduler.cmo -c -impl lib/scheduler.ml)
# File "lib/scheduler.ml", lines 34-40, characters 10-6:
# 34 | ..........Hashtbl.MakeSeeded (struct
# 35 |     type t = Stream_identifier.t
# 36 | 
# 37 |     let equal = Stream_identifier.( === )
# 38 | 
# 39 |     let hash i k = Hashtbl.seeded_hash i k
# 40 |   end)
# Error: Modules do not match:
#        sig
#          type t = H2__.Stream_identifier.t
#          val equal : Int32.t -> Int32.t -> bool
#          val hash : int -> 'a -> int
#        end
#      is not included in Hashtbl.SeededHashedType
#      The value `seeded_hash' is required but not provided
#      File "hashtbl.mli", line 399, characters 4-36: Expected declaration

@samoht samoht merged commit f0b7334 into ocaml:master Oct 25, 2022
@samoht
Copy link
Member

samoht commented Oct 25, 2022

Merging this as the remaining errors do not seem related to the PR. @icristescu could you open issues so that these remaining errors are not forgotten? Thanks

@icristescu
Copy link
Contributor Author

I think the issue with the tests should be solved by mirage/irmin#2127. It is an issue with irmin packages after all, I'll open a PR to fix the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants