-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] irmin project (3.4.3) #22321
Conversation
…ils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.4.3) CHANGES: ### Fixed - **irmin-pack** - Fix read-only opening flags of mapping for read-only opening of stores that do not have read-write rights on the files. (mirage/irmin#2121, @Ngoguey42)
c8ce59e
to
7b5a27a
Compare
Why also adding this restrictions to the other packages? Only the tests for those were failing and this can be ignored or disabled at test level |
Co-authored-by: Kate <kit.ty.kate@disroot.org>
7b5a27a
to
5bf3a13
Compare
@kit-ty-kate I moved the os restriction on the tests only. |
Some tests for irmin-https are flaky, they could be the cause of the timeouts in the CI.
The error in the CI seems to me unrelated to irmin, so maybe this can be merged? Let me know if you think I need to fix something on irmin side. Thanks!
|
Merging this as the remaining errors do not seem related to the PR. @icristescu could you open issues so that these remaining errors are not forgotten? Thanks |
I think the issue with the tests should be solved by mirage/irmin#2127. It is an issue with irmin packages after all, I'll open a PR to fix the current release. |
CHANGES:
Fixed
do not have read-write rights on the files. (irmin-pack: Fix mmap RO opening flags mirage/irmin#2121, @Ngoguey42)