-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cohttp.6.0.0~alpha0 uses the bytes library #23262
Conversation
Adjust constraint accordingly.
I believe that's the right rune but it's the first time I'm doing it. |
Do you have the log of the error? I can fix it upstream before the next release |
Oops, sorry:
So the upstream fix is likely to just remove |
The failure was seen in the opam-repository CI, see ocaml/opam-repository#23262 (comment) Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
I am suprised that if fails with
So this one should have worked. Does it have to do with further changes in dune? |
I don't think so, but I'm not completely up to date about what changed in 5.0. Possibly the compiler-provided META files (that dune uses if dune >= 2.9-ish and ocaml >= 5) do not include bytes? In any case, this seems to be similar to #23012 for example which would fail with a recent dune too. |
Thanks, I updated the wiki to mention the need for both changes. |
Cohttp top fails with
|
Fails with ``` File "lwt/websocket_lwt_unix.ml", line 87, characters 35-37: # 87 | (fun () -> drain_handshake req ic oc nonce) # ^^ # Error: This expression has type # Conduit_lwt_unix.ic = Lwt_io.input Lwt_io.channel # but an expression was expected of type # Response.IO.ic = Cohttp_lwt_unix__Input_channel.t ```
All other failures are addressed in separate PRs |
Thanks |
The failure was seen in the opam-repository CI, see ocaml/opam-repository#23262 (comment) Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
The failure was seen in the opam-repository CI, see ocaml/opam-repository#23262 (comment) Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Adjust constraint accordingly.