[new release] atdts, atds, atdpy, atdj, atdgen, atdgen-runtime, atdgen-codec-runtime and atd (2.12.0) #23785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-codec-runtime and atd (2.12.0) CHANGES: * atdgen: Annotate generated code with types to disambiguate OCaml classic variants (ahrefs/atd#331) * atdpy: Support the option type more correctly so that it follows ATD's convention for JSON encoding. This allows compatibility with JSON produced by other tools of the ATD suite. The Python type, however, is still a nullable (`Optional`) to make things simpler for Python programmers. This prevents distinguishing `["Some", "None"]` from `"None"` which both translate to `None` in Python. (ahrefs/atd#332) * (BREAKING) atdgen: revert default encoding of int64 values as string (ahrefs/atd#330) * atdgen: Support `<json repr="string">` for `int` values (ahrefs/atd#330) * atdpy: Treat default field values as expressions to evaluate each time they're assigned to a field. This allows the use of mutable defaults such as lists (ahrefs/atd#339)
mseri
reviewed
May 15, 2023
| "atdgen-runtime" {>= "2.1.0"} | ||
| "atdgen-codec-runtime" {with-test} | ||
| "biniou" {>= "1.0.6"} | ||
| "yojson" {>= "2.0.1"} |
There was a problem hiding this comment.
This lower bound may need an update:
#=== ERROR while compiling atdgen.2.12.0 ======================================#
# context 2.2.0~alpha~dev | linux/x86_64 | ocaml-variants.5.1.0+trunk | pinned(https://github.com/ahrefs/atd/releases/download/2.12.0/atdts-2.12.0.tbz)
# path ~/.opam/5.1/.opam-switch/build/atdgen.2.12.0
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p atdgen -j 255 @install
# exit-code 1
# env-file ~/.opam/log/atdgen-7-f5ad5a.env
# output-file ~/.opam/log/atdgen-7-f5ad5a.out
### output ###
# (cd _build/default && /home/opam/.opam/5.1/bin/ocamlopt.opt -w -40 -w -27 -safe-string -g -I atdgen/src/.atdgen_emit.objs/byte -I atdgen/src/.atdgen_emit.objs/native -I /home/opam/.opam/5.1/lib/atd -I /home/opam/.opam/5.1/lib/biniou -I /home/opam/.opam/5.1/lib/easy-format -I /home/opam/.opam/5.1/lib/re -I /home/opam/.opam/5.1/lib/yojson -intf-suffix .ml -no-alias-deps -open Atdgen_emit -o atdgen/src/.atdgen_emit.objs/native/atdgen_emit__Oj_mapping.cmx -c -impl atdgen/src/oj_mapping.ml)
# File "atdgen/src/oj_mapping.ml", line 97, characters 19-36:
# 97 | let j = Json.get_json_int an in
# ^^^^^^^^^^^^^^^^^
# Error: Unbound value Json.get_json_int
# Hint: Did you mean get_json_list?
|
I just pushed a fix for the reverse dependency checks (previous atdgen releases can't use the latest atd). |
|
Looks good, thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project page: https://github.com/ahrefs/atd
CHANGES:
classic variants (Annotate generated code with types to disambiguate OCaml classic variants ahrefs/atd#331)
ATD's convention for JSON encoding. This allows compatibility with
JSON produced by other tools of the ATD suite. The Python type,
however, is still a nullable (
Optional) to make things simpler forPython programmers. This prevents distinguishing
["Some", "None"]from
"None"which both translate toNonein Python. (atdpy treats option as nullable ahrefs/atd#332)<json repr="string">for int types ahrefs/atd#330)<json repr="string">forintvalues (Allow<json repr="string">for int types ahrefs/atd#330)they're assigned to a field. This allows the use of mutable defaults such as
lists (atdpy: fix handling of fields defaulting to the empty list ahrefs/atd#339)