Add bounds for removed dune ctypes 0.1 extension #24506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ctypes extension in Dune is documented as experimental (and has version 0.x) so is not subject to the same compatibility as the rest of Dune. Dune 3.11.0 removed versions 0.1 and 0.2 of this extension, so packages using it need to build with `dune < 3.11`. Affected packages need to migrate to version 0.3. This should be just a matter of changing the version of the extension in `dune-project`, but: - it requires `(lang dune 3.7)` - if C code refers to local include paths, these are now relative to the where the stanza is located. This avoids the need to specify paths twice. See ocaml/dune#6883.
|
cc:
|
21 tasks
|
I'll wait until this merged to submit the 3.11.0 run. |
|
Actually I just submitted it; I can restart the failures once this one is merged. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ctypes extension in Dune is documented as experimental (and has
version 0.x) so is not subject to the same compatibility as the rest of
Dune.
Dune 3.11.0 removed versions 0.1 and 0.2 of this extension, so packages
using it need to build with
dune < 3.11.Affected packages need to migrate to version 0.3. This should be just a
matter of changing the version of the extension in
dune-project, but:(lang dune 3.7)where the stanza is located. This avoids the need to specify paths
twice. See ctypes 0.3: run commands in stanza directory dune#6883.