[new release] mirage-flow, mirage-flow-unix and mirage-flow-combinators (4.0.0) #24959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
force-pushed
the
release-mirage-flow-v4.0.0
branch
from
7508af0 to
e5b9504
Compare
|
see #24960 for fixing more revdeps |
…rs (4.0.0) CHANGES: - Redefine `close` semantics, which no longer is a `` shutdown `read_write `` (mirage/mirage-flow#49 @hannesm) - Add ``shutdown : flow -> [ `read | `write | `read_write ] -> unit Lwt.t`` (@djs55 @hannesm mirage/mirage-flow#16 mirage/mirage-flow#18 mirage/mirage-flow#48) - Remove SHUTDOWNABLE signature (@djs55 mirage/mirage-flow#17, rebased into mirage/mirage-flow#48)
hannesm
force-pushed
the
release-mirage-flow-v4.0.0
branch
from
e5b9504 to
acbb989
Compare
|
re-iterating here from #24960 #24952:
Please keep in mind, that (a) there's now shutdown and (b) close semantics changed (see #24959 for the release and the details at https://mirage.github.io/mirage-flow/mirage-flow/Mirage_flow/module-type-S/index.html (if you wonder why you appear in the list above -> take a look into the "maintainers" metadata of your opam package) |
|
remaining CI error (timeout of solver, ...) are unrelated. This is fine to merge from my point of view. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow implementations and combinators for MirageOS
CHANGES:
closesemantics, which no longer is ashutdown `read_write(Adapt close documentation to really close the flow. mirage/mirage-flow#49 @hannesm)
shutdown : flow -> [ `read | `write | `read_write ] -> unit Lwt.t(@djs55 @hannesm Clear up confusion between FLOW close, shutdown mirage/mirage-flow#16 Support both FLOW.disconnect and FLOW.close mirage/mirage-flow#18 Add Mirage_flow.shutdown: flow -> [ read | write | read_write ] -> unit Lwt.t mirage/mirage-flow#48)