Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to read the opam file inside the archive on a version pin #4608

Open
kit-ty-kate opened this issue Mar 19, 2021 · 2 comments · May be fixed by #4931
Open

Remove the need to read the opam file inside the archive on a version pin #4608

kit-ty-kate opened this issue Mar 19, 2021 · 2 comments · May be fixed by #4931
Assignees

Comments

@kit-ty-kate
Copy link
Member

In #4580 @rjbou fixed a bug in the case we're reading the opam file inside the archive but the opam file is invalid. It seems that we should not look into the archive at all. We should review that at some point.

@dra27
Copy link
Member

dra27 commented Mar 19, 2021

Linking in the original issue #3651 and the fix #3726

@dra27
Copy link
Member

dra27 commented Mar 19, 2021

This Dockerfile also demonstrates the original problem:

FROM ocaml/opam:alpine-3.12-ocaml-4.07
RUN git clone https://github.com/ocaml/opam.git
WORKDIR opam
RUN git checkout 2.0.3 && sed -i -e 's/\.ua//' src_ext/Makefile.sources
RUN eval $(opam env) && ./configure && make lib-ext && make
RUN sudo cp opam /usr/bin/opam
RUN sudo apk add m4
RUN opam --version
RUN rm -rf ~/.opam && opam init -ya 'git+https://github.com/ocaml/opam-repository.git#7484a9dd' -c ocaml-base-compiler.4.07.1
RUN opam repo add coq-core-dev https://coq.inria.fr/opam/core-dev
RUN opam pin add coq 8.9.dev -y
RUN opam exec -- coqc --version
RUN opam pin add coq 8.8.2 -y
RUN opam exec -- coqc --version

The 2.0.4 tag executes correctly.

@rjbou rjbou self-assigned this Jul 2, 2021
@rjbou rjbou linked a pull request Nov 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants