Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin version: don't error if archive opam file is malformed #4580

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Mar 4, 2021

@rjbou rjbou added the KIND: BUG label Mar 4, 2021
@rjbou rjbou added this to the 2.1.0~rc milestone Mar 4, 2021
@kit-ty-kate
Copy link
Member

In my opinion the check itself shouldn't be there as the version field the archive is often either not present or outright false.

@rjbou
Copy link
Collaborator Author

rjbou commented Mar 8, 2021

In that case, there is (ftm) no way to determine which source it is, and we will need to download it (extract archive) each time.

@rjbou rjbou force-pushed the pin-version-fix branch from 23f73bd to 7297761 Compare March 26, 2021 10:17
@rjbou rjbou merged commit 7f15f18 into ocaml:master Mar 26, 2021
@rjbou rjbou mentioned this pull request Apr 1, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam install fails when having pinned a package with an empty opam file inside its archive
3 participants