-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opam lock
includes the host-arch
and host-system
packages
#6042
Comments
Further discussion at https://discuss.ocaml.org/t/dune-lockfiles-are-not-cross-platform-how-should-we-approach-checking-them-into-version-control/14992/19 What introduced this is the PR ocaml/opam-repository#25861
I'm really puzzled why a workaround was established so late in the release cycle, while adding the required logic to opam before 2.2 would have been a smooth sail. Now the workaround - a matrix of packages - will be hard to remove: due to backwards compatibility - only once 2.2.0 is out of support it will allow removal of these packages. It may be that #2247 outlines a solution. |
Summary: These are architecture-dependent and as such not always satisfiable. See also ocaml/opam#6042 Reviewed By: geralt-encore Differential Revision: D62236842 fbshipit-source-id: d985556513d7367a0c0b1db6252104d9325015e0
All the |
Indeed - the additional packages have had an unintended consequence to what were already imprecise/non-portable lock files. There’s work in flight to address that, but just to note that those packages were never intended as a workaround - in terms of the solver, they are the solution (the switch variable part of #2247 makes slightly less sense in opam 2.x than it did in 1.2, which is one of the reasons my implementation towards it in #2930 never made it) |
When running
opam lock
, thehost-arch
andhost-system
packages are included in the lock file. I believe they shouldn't.In my specific case I ended up with
host-arch-x86_64
andhost-system-other
being listed. I removed them by hand from the lockfile so that my colleagues on other arches/systems would still be able to use the lockfile.The text was updated successfully, but these errors were encountered: