Add ? operator to filter syntax #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
defined-operator
branch
4 times, most recently
from
ebaf3a6 to
7e6c90a
Compare
|
The two temporary commits are obviously just that, but note that 6b2a19f includes changes which should be made, since lib-ext is presently using an older release of opam-file-format |
|
Thanks! We'll also need to update the doc (https://github.com/ocaml/opam/blob/master/doc/pages/Manual.md#filters and general syntax above) |
The ? operator evaluates to false if the expression is undefined (i.e.
contains undefined variables) and true in all other instances.
This operator removes the need for evil uses of "%{variable}%" (which
expands to an empty string if variable is undefined).
Signed-off-by: David Allsopp <david.allsopp@metastack.com>
|
Docs updated, and also the temporary lib-ext pointer changed. Is there anything else I need to do to this one? |
|
Nope, seems all OK to me. The temporary commits actually don't need to be temporary anymore (it's fine to require the master version of opam-file-format for CI !) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also ocaml/opam-file-format#4 - this PR should have a commit updating
src_extbefore it is merged.The
?operator evaluates to false if the expression is undefined (i.e. contains undefined variables) and true in all other instances.This operator removes the need for evil uses of
"%{variable}%"(which expands to an empty string if variable is undefined). In particular, for theocaml-systempackage, it allows a slightly less unclearavailablefield: