Clickable links in opam show #4568
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows generation of OSC 8 sequences for clickable hyperlinks.
rjbou
reviewed
Feb 26, 2021
| try | ||
| let basic_contents = detail_printer ~prettify:true ?normalise ~sort st nv item in | ||
| let contents_url = OpamUrl.parse basic_contents in | ||
| if OpamUrl.(contents_url.transport = "http" || contents_url.transport = "https") then |
There was a problem hiding this comment.
A reason to not use the backend field ?
avsm
reviewed
Feb 26, 2021
| @@ -442,6 +442,12 @@ let carriage_delete = | |||
| else | |||
| carriage_delete_unix | |||
|
|
|||
| let url ~ref ~label = | |||
| if not (color ()) || Sys.win32 && get_win32_console_shim `stdout Mode = Shim then | |||
There was a problem hiding this comment.
Might be worth a comment linking to the handy https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda which describes the escape codes for Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A piece of sleeplessness-induced silliness looking at #4565 - if a field in opam show parses as a URL, turn the field marker into a clickable hyperlink.
Not for 2.1 (if at all, but the function might be useful, even if not used in opam show)