-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli version - environment variable edition #4606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
PR: WIP
Not for merge at this stage
labels
Mar 17, 2021
Remaining:
|
rjbou
force-pushed
the
cli-version-envvar-edition
branch
from
March 19, 2021 15:26
2f804f7
to
d0b6ffb
Compare
rjbou
removed
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
PR: WIP
Not for merge at this stage
labels
Mar 19, 2021
rjbou
force-pushed
the
cli-version-envvar-edition
branch
from
March 26, 2021 16:40
0bb77b3
to
df63cce
Compare
AltGr
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty great! And finally we can have the documentation of the environment variables besides them :)
Two small nitpicks:
- remember to update the doc index.html when you add modules
- in
[WARNING] OPAMNODEPEXTS was added in version 2.1 of the opam CLI, but version 2.0 has been requested, which is older.
it is not completely clear wether the variable was used nonetheless or was ignored. MaybeOPAMNODEPEXTS was ignored because CLI v. 2.0 was requested and it was introduced in v.2.1
?
rjbou
force-pushed
the
cli-version-envvar-edition
branch
from
April 6, 2021 09:14
64f09fb
to
2a5d412
Compare
…f string environment variables
…only if launched via cli
…set envrioonemtn variables
core config: export yes env
rjbou
force-pushed
the
cli-version-envvar-edition
branch
from
April 6, 2021 10:43
2a5d412
to
d4013c6
Compare
rjbou
force-pushed
the
cli-version-envvar-edition
branch
from
April 6, 2021 11:29
bb9a7d6
to
4818821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New opam environment variable handling. They are defined per lib, and defined and loaded only at opam client start (no more on library loading). There is no more direct access, each environment variable have its associated field in its lib config, or can be accessed throw
OpamXxxConfig.Env.<var>
function.When defined in
OpamArg
, the cli version is required, to handle cli versioning of environment variable in a slightly different way than options: if not defined in current cli, a warning is printed and it is ignored.