Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard format upgrade triggered by a reinit acts as a successful command #4756

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jul 20, 2021

fix #4748

@rjbou rjbou requested review from AltGr and dra27 July 20, 2021 10:23
@rjbou rjbou changed the title Hard format upgrade trigerred by a reinit acts as a sucessful command Hard format upgrade trigered by a reinit acts as a successful command Jul 20, 2021
@rjbou rjbou added this to the 2.1.0 milestone Jul 20, 2021
@rjbou rjbou changed the title Hard format upgrade trigered by a reinit acts as a successful command Hard format upgrade triggered by a reinit acts as a successful command Jul 20, 2021
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo a comment typo!

src/state/opamFormatUpgrade.mli Outdated Show resolved Hide resolved
src/client/opamCommands.ml Outdated Show resolved Hide resolved
@AltGr
Copy link
Member

AltGr commented Jul 21, 2021

Very nice, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants