Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli regression on switch creation with packages #4853

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Sep 30, 2021

Fix #4843

$ OPAMCLI=2.0 opam switch create . 4.12.0+options --packages=ocaml-option-flambda --show

<><> Installing new switch packages ><><><><><><><><><><><><><><><><>
Switch invariant: ["ocaml-variants" {= "4.12.0+options"} "ocaml-option-flambda"]
The following actions would be performed:
  ∗ install base-bigarray        base
  ∗ install base-threads         base
  ∗ install base-unix            base
  ∗ install ocaml-option-flambda 1
  ∗ install ocaml-variants       4.12.0+options
  ∗ install ocaml-config         2
  ∗ install ocaml                4.12.0
===== ∗ 7 =====

$ opam switch create . 4.12.0+options --packages=ocaml-option-flambda --show 
[ERROR] Individual package and option '--packages' can not be specified at the same time. Use '--packages' or '--formula instead', e.g.
        opam switch create flambda --packages=ocaml-variants.4.12.0+options,ocaml-option-flambda

@rjbou rjbou added this to the 2.1.1 milestone Sep 30, 2021
@dra27
Copy link
Member

dra27 commented Oct 8, 2021

The msvc64 failure on AppVeyor can be ignored for now

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for tweaking the example shown - open bug reports on other ones suggest users really do read them occasionally ☺

src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/client/opamArg.mli Show resolved Hide resolved
src/client/opamCLIVersion.ml Show resolved Hide resolved
tests/reftests/cli-versioning.test Outdated Show resolved Hide resolved
rjbou added 3 commits October 15, 2021 11:02
packages option with cli 2.0, and specific error message with cli 2.1
…tions and argument handling (avail on cli 2.0)
@rjbou rjbou merged commit b941f86 into ocaml:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI regression in opam init in 2.1.0
4 participants