Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve variables before polling system #4892

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Resolve variables before polling system #4892

merged 6 commits into from
Aug 4, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 5, 2021

fix #4885

@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 5, 2021
@rjbou rjbou requested review from kit-ty-kate and dra27 and removed request for kit-ty-kate November 5, 2021 18:39
rjbou
rjbou commented Nov 12, 2021
View reviewed changes
src/client/opamCommands.ml Outdated Show resolved Hide resolved
rjbou
rjbou commented Dec 17, 2021
View reviewed changes
src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate mentioned this pull request Jan 18, 2022
Closed
@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jul 26, 2022
@kit-ty-kate kit-ty-kate mentioned this pull request Jul 26, 2022
Merged
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jul 26, 2022
kit-ty-kate
kit-ty-kate approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor reformat suggestion, LGTM.

dra27
dra27 reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible restructuring just to ensure the "correct" version of the lookup is used in the code.

Is it worth making ~env mandatory in the API? i.e. outside of OpamSysPoll, do we ever want/need to be looking up these without first checking the environment (I didn't check for other call sites)

master_changes.md Outdated Show resolved Hide resolved
master_changes.md Outdated Show resolved Hide resolved
master_changes.md Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
@rjbou
Copy link
Collaborator Author

rjbou commented Aug 1, 2022

We need the ~env to specify the environment to look in for variables.

dra27
dra27 reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible further disentangling of laziness!

src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
src/state/opamSysPoll.ml Outdated Show resolved Hide resolved
@rjbou rjbou merged commit 06f889f into ocaml:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 left review comments

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

os-distribution
3 participants
@rjbou @kit-ty-kate @dra27