-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary copies/move when fetching archives #5018
Conversation
2e95ccb
to
981e534
Compare
981e534
to
12145f9
Compare
Reworked it, it was more tedious than at first sight |
thought: It complicates the code while it removes a unneeded |
057819c
to
4132416
Compare
ed87009
to
9efaeda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a test to highlight the updates.
On my side, the code seems good. But from previous comments it seems that I wrote a part of it, so another air of eyes to look at, to the test too.
6002953
to
7e5e505
Compare
lgtm now |
7e5e505
to
79debba
Compare
Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
79debba
to
0fa927c
Compare
In #4586 (comment) we can see that to download an archive, opam currently does basically:
The three first commands can be combined into one very easily, giving us:
Fixes #5939