Consistent accepted repository links #6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
approved these changes
Jul 11, 2024
dra27
reviewed
Jul 15, 2024
kit-ty-kate
reviewed
Jul 15, 2024
Keryan-dev
force-pushed
the
consistent-repo-url
branch
from
341769c to
14aab5b
Compare
kit-ty-kate
reviewed
Jul 16, 2024
Keryan-dev
force-pushed
the
consistent-repo-url
branch
from
14aab5b to
41f96aa
Compare
rjbou
reviewed
Jul 25, 2024
src/client/opamCommands.ml
Outdated
Comment on lines
2713
to
2715
| `Pre " opam switch create trunk --repos \ | ||
| default,beta=git+https://github.com/ocaml/ocaml-beta-repository.git \ | ||
| default,beta=https://github.com/ocaml/ocaml-beta-repository.git \ | ||
| ocaml-variants.4.10.0+trunk"; |
There was a problem hiding this comment.
This should also be guarder by a cli version, no ?
`Pre (Printf.sprintf
" opam switch create trunk --repos \
default,beta=https://github.com/ocaml/ocaml-beta-repository.git \
ocaml-variants.4.10.0+trunk"
(if OpamCLIVersion.Op.(cli @>= cli2_3) then "" else "git+"));
new behaviour in 2.3, old behaviour is stil available with cli < 2.3
rjbou
force-pushed
the
consistent-repo-url
branch
from
66d4a21 to
2379d84
Compare
rjbou
approved these changes
Aug 9, 2024
kit-ty-kate
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opam switch create foo --repos bar=[url]should no longer requiregit+to be accepted. Consistent withopam repository add.fixes #4673